Bug 264146 - [MSE] MediaSource::isEnded is unnecessarily passed to all methods
Summary: [MSE] MediaSource::isEnded is unnecessarily passed to all methods
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jean-Yves Avenard [:jya]
URL:
Keywords: InRadar
Depends on:
Blocks: 264134
  Show dependency tree / graph
 
Reported: 2023-11-03 03:26 PDT by Jean-Yves Avenard [:jya]
Modified: 2023-11-08 08:04 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Yves Avenard [:jya] 2023-11-03 03:26:41 PDT 
sub-task of bug 264134

Whenever a method is called in the SourceBufferPrivate, the value of MediaSource::isEnded() is passed. But the MediaSourcePrivate was already notified that the MediaSource has been ended and each SourceBufferPrivate keep a reference to the MediaSourcePrivate.

So we can simplify the code and remove some unnecessary methods.
Comment 1 Radar WebKit Bug Importer 2023-11-03 03:27:18 PDT 
<rdar://problem/117899460>
Comment 2 Jean-Yves Avenard [:jya] 2023-11-03 03:44:33 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/19940
Comment 3 EWS 2023-11-08 08:04:13 PST 
Committed 270390@main (b21ca9944221): <https://commits.webkit.org/270390@main>

Reviewed commits have been landed. Closing PR #19940 and removing active labels.