Bug 264162 - SVG test gardening
Summary: SVG test gardening
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords: InRadar
Depends on:
Blocks: 90738
  Show dependency tree / graph
 
Reported: 2023-11-03 09:30 PDT by Nikolas Zimmermann
Modified: 2023-11-05 15:25 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2023-11-03 09:30:45 PDT 
I'd like the following to pass without any issues:

1. Legacy without pixel tests

run-webkit-tests --no-build --nocheck-sys-deps svg

2. Legacy with pixel tests

run-webkit-tests --no-build --nocheck-sys-deps --additional-platform-directory=$PWD/LayoutTests/platform/mac-sonoma-wk2-pixel  --pixel-tests --tolerance=0 svg

3. LBSE with pixel tests

run-webkit-tests --no-build --nocheck-sys-deps --additional-platform-directory=$PWD/LayoutTests/platform/mac-sonoma-wk2-lbse-text --additional-platform-directory=$PWD/LayoutTests/platform/mac-sonoma-wk2-pixel --additional-expectations=$PWD/LayoutTests/platform/mac-sonoma-wk2-lbse-text/TestExpectations --internal-feature=LayerBasedSVGEngineEnabled=true --pixel-tests --tolerance=0 svg

Currently there are a few issues that need to be fixed.
Comment 1 Nikolas Zimmermann 2023-11-05 04:13:45 PST 
Pull request: https://github.com/WebKit/WebKit/pull/20008
Comment 2 EWS 2023-11-05 15:24:46 PST 
Committed 270249@main (b8e760f427db): <https://commits.webkit.org/270249@main>

Reviewed commits have been landed. Closing PR #20008 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-11-05 15:25:16 PST 
<rdar://problem/117974311>