Bug 264207 - Build failure of AccessibilityNotificationHandler.cpp
Summary: Build failure of AccessibilityNotificationHandler.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: ChangSeok Oh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-11-04 09:56 PDT by ChangSeok Oh
Modified: 2023-11-07 10:00 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description ChangSeok Oh 2023-11-04 09:56:21 PDT 
I don't know why this happens to me now. I got a build failure on AccessibilityNotificationHandler.cpp

$ Tools/Scripts/build-webkit --gtk --makeargs="-j7"

```
/app/webkit/Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityNotificationHandler.cpp:50:46: error: no member named 'addNotificationObserver' in 'WebCore::Accessib
ilityAtspi'                                                                                                                                                               
    WebCore::AccessibilityAtspi::singleton().addNotificationObserver(this, [this](WebCore::AccessibilityObjectAtspi& element, const char* notificationName, WebCore::Acces
sibilityAtspi::NotificationObserverParameter parameter) {                                                                                                                 
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^                                                                                                                            
/app/webkit/Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityNotificationHandler.cpp:50:186: error: no type named 'NotificationObserverParameter' in 'WebCore::Acc
essibilityAtspi'                                                                                                                                                          
    WebCore::AccessibilityAtspi::singleton().addNotificationObserver(this, [this](WebCore::AccessibilityObjectAtspi& element, const char* notificationName, WebCore::Acces
sibilityAtspi::NotificationObserverParameter parameter) {                                                                                                                 
                                                                                                                                                            ~~~~~~~~~~~~~~
~~~~~~~~~~~~~~~^                                                                                                                                                          
/app/webkit/Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityNotificationHandler.cpp:95:46: error: no member named 'removeNotificationObserver' in 'WebCore::Acces
sibilityAtspi'                                                                                                                                                                WebCore::AccessibilityAtspi::singleton().removeNotificationObserver(this);                                                                                            
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^                                                                                                                            3 errors generated.                                                                                                                                  
[5289/5406] Building CXX object Tools/TestWebKitAPI/CMakeFiles/TestWebCore.dir/Tests/WebCore/TransformationMatrix.cpp.o
```

The constructor and destructor of AccessibilityNotificationHandler use AccessibilityAtspi's methods guarded by DEVELOPER_MODE.
Comment 1 Radar WebKit Bug Importer 2023-11-04 09:56:29 PDT 
<rdar://problem/117946319>
Comment 2 ChangSeok Oh 2023-11-04 10:03:11 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/19999
Comment 3 ChangSeok Oh 2023-11-04 10:06:39 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/20000
Comment 4 EWS 2023-11-07 10:00:28 PST 
Committed 270333@main (0335988960fa): <https://commits.webkit.org/270333@main>

Reviewed commits have been landed. Closing PR #20000 and removing active labels.