Bug 264230 - [LBSE] Rework SVG resource invalidation
Summary: [LBSE] Rework SVG resource invalidation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords: InRadar
Depends on: 265179
Blocks: 90738
  Show dependency tree / graph
 
Reported: 2023-11-05 14:51 PST by Nikolas Zimmermann
Modified: 2023-11-22 04:56 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2023-11-05 14:51:57 PST 
As mentioned in my WKCM '23 presentation - the invalidation in the legacy SVG engine is tricky, fragile and full of issues. For LBSE we should try hard to come up with a better mechanism, based on the "recently" introduced ReferencedSVGResources, which are superior to SVGResources & co.
Comment 1 Nikolas Zimmermann 2023-11-05 14:57:57 PST 
Pull request: https://github.com/WebKit/WebKit/pull/20016
Comment 2 Radar WebKit Bug Importer 2023-11-12 14:52:11 PST 
<rdar://problem/118306382>
Comment 3 EWS 2023-11-20 17:47:36 PST 
Committed 270992@main (4e524359e8b3): <https://commits.webkit.org/270992@main>

Reviewed commits have been landed. Closing PR #20016 and removing active labels.
Comment 4 WebKit Commit Bot 2023-11-20 22:56:38 PST 
Re-opened since this is blocked by bug 265179
Comment 5 Nikolas Zimmermann 2023-11-21 03:05:27 PST 
Pull request: https://github.com/WebKit/WebKit/pull/20782
Comment 6 EWS 2023-11-21 07:42:26 PST 
Committed 271017@main (e8f289a6906b): <https://commits.webkit.org/271017@main>

Reviewed commits have been landed. Closing PR #20782 and removing active labels.