Bug 264297 - REGRESSION (270226@main): Profiling symbols missing from JavaScriptCore.framework
Summary: REGRESSION (270226@main): Profiling symbols missing from JavaScriptCore.frame...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on: 263697
Blocks:
  Show dependency tree / graph
 
Reported: 2023-11-06 15:37 PST by David Kilzer (:ddkilzer)
Modified: 2023-11-06 20:00 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2023-11-06 15:37:51 PST 
Profiling symbols missing from JavaScriptCore.framework.

This happened after introducing `libJavaScriptCore.a` in 270226@main since these two lines were moved from `JavaScriptCore.xcconfig` to `libJavaScriptCore.xcconfig` instead of to `BaseTarget.xcconfig`, which caused `-fprofile-instr-generate` not to be included when linking `JavaScriptCore.framework`:

```
CLANG_INSTRUMENT_FOR_OPTIMIZATION_PROFILING = $(CLANG_INSTRUMENT_FOR_OPTIMIZATION_PROFILING_$(ENABLE_LLVM_PROFILE_GENERATION));
CLANG_INSTRUMENT_FOR_OPTIMIZATION_PROFILING_ENABLE_LLVM_PROFILE_GENERATION = YES;
```
Comment 1 Radar WebKit Bug Importer 2023-11-06 15:38:13 PST 
<rdar://problem/118023550>
Comment 2 David Kilzer (:ddkilzer) 2023-11-06 15:43:26 PST 
Pull request: https://github.com/WebKit/WebKit/pull/20070
Comment 3 EWS 2023-11-06 20:00:58 PST 
Committed 270306@main (60d419eb1b25): <https://commits.webkit.org/270306@main>

Reviewed commits have been landed. Closing PR #20070 and removing active labels.