Bug 264354 - REGRESSION(268354@main): Text gets shadow if its container has a filter drop-shadow
Summary: REGRESSION(268354@main): Text gets shadow if its container has a filter drop-...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-11-07 12:01 PST by Said Abou-Hallawa
Modified: 2023-11-08 16:42 PST (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2023-11-07 12:01:27 PST
Open the attached test case.

Result: The text and its container <div> are rendered with drop shadow.
Expected: Only the container <div> is rendered with drop shadow.

Other repro steps (assuming the web page will remain unchanged):

1. Go to https://fr.bam-karaokebox.com/booking?city=Paris#capacity[]=10&date=2023-12-10&city=Paris
2. Click on “Capacité”

This is in fact a regression of https://commits.webkit.org/266544@main in which the drop shadow is represented as a filter style. This change did not consider they are different things and can coexist.

At the time https://commits.webkit.org/266544@main was submitted, the CoreGraphics filters was an internal feature. Enabling CoreGraphics filters by default in ttps://commits.webkit.org/268354@main exposed this regression.
Comment 1 Said Abou-Hallawa 2023-11-07 12:02:40 PST
rdar://117987393
Comment 2 Said Abou-Hallawa 2023-11-07 13:04:04 PST
Pull request: https://github.com/WebKit/WebKit/pull/20122
Comment 3 EWS 2023-11-08 16:42:04 PST
Committed 270414@main (f4c2de375a56): <https://commits.webkit.org/270414@main>

Reviewed commits have been landed. Closing PR #20122 and removing active labels.