Bug 264394 - [web-animations] move shared timing data between AnimationEffect and AcceleratedEffect to a dedicated struct
Summary: [web-animations] move shared timing data between AnimationEffect and Accelera...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks: 250970
  Show dependency tree / graph
 
Reported: 2023-11-08 02:45 PST by Antoine Quint
Modified: 2023-11-08 12:15 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2023-11-08 02:45:57 PST 
The AnimationEffect and AcceleratedEffect classes share a number of timing-related properties. These properties are also used to resolve timing and progress while applying animations, so it will be important to share this timing-related logic across AnimationEffect and AcceleratedEffect as well. We should add a new supporting struct to encompass this information and contain this resolution logic.
Comment 1 Antoine Quint 2023-11-08 02:53:39 PST 
Pull request: https://github.com/WebKit/WebKit/pull/20154
Comment 2 EWS 2023-11-08 12:14:07 PST 
Committed 270402@main (8f40ab2aadbb): <https://commits.webkit.org/270402@main>

Reviewed commits have been landed. Closing PR #20154 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-11-08 12:15:33 PST 
<rdar://problem/118133395>