Bug 264434 - Move the selfNeedsLayout() check out of RenderElement::repaintAfterLayoutIfNeeded()
Summary: Move the selfNeedsLayout() check out of RenderElement::repaintAfterLayoutIfNe...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-11-08 13:55 PST by Simon Fraser (smfr)
Modified: 2023-11-08 16:22 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2023-11-08 13:55:56 PST 
RenderElement::repaintAfterLayoutIfNeeded() shouldn't be consulting selfNeedsLayout() internally; this is confusing (maybe wrong), and repaintAfterLayoutIfNeeded() is called from RenderLayer code where we're outside of layout.
Comment 1 Radar WebKit Bug Importer 2023-11-08 13:56:51 PST 
<rdar://problem/118138171>
Comment 2 Simon Fraser (smfr) 2023-11-08 14:01:30 PST 
Pull request: https://github.com/WebKit/WebKit/pull/20188
Comment 3 EWS 2023-11-08 16:21:57 PST 
Committed 270412@main (e6d3796b1e08): <https://commits.webkit.org/270412@main>

Reviewed commits have been landed. Closing PR #20188 and removing active labels.