Bug 264446 - Remove special handling of ::before and ::after on RUBY elements
Summary: Remove special handling of ::before and ::after on RUBY elements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-11-08 15:19 PST by Ahmad Saleem
Modified: 2023-11-16 06:07 PST (History)
4 users (show)

See Also:

Attachments
Local Build 'RenderTreeBuilderRuby' file (as TXT) (14.76 KB, text/plain)
2023-11-08 15:19 PST, Ahmad Saleem 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-11-08 15:19:04 PST 
Created attachment 468524 [details]
Local Build 'RenderTreeBuilderRuby' file (as TXT)

Hi Team,

While going through Blink's commit, I came across following clean-up patch but I don't know whether we can do this or not but just wanted to raise this bug to get input.

@Alan - it would be good to get your insight due to on-going 'Ruby' related Layout work, you are leading.

Blink Commit: https://chromium.googlesource.com/chromium/blink/+/81eb8745dfd7d21fc9588220eed989d901cb7276

WebKit Source: Source/WebCore/rendering/updating/RenderTreeBuilderRuby.cpp

___

I have local patch to remove and do all clean-up, attaching here.

NOTE: I didn't run any local tests or WPT tests but just wanted to get input before doing so.

Thanks!
Comment 1 Radar WebKit Bug Importer 2023-11-15 15:20:14 PST 
<rdar://problem/118478034>
Comment 2 Ahmad Saleem 2023-11-15 15:47:16 PST 
PR Attempt - let's give EWS something to test: https://github.com/WebKit/WebKit/pull/20565
Comment 3 EWS 2023-11-16 06:07:54 PST 
Committed 270823@main (3c701132f001): <https://commits.webkit.org/270823@main>

Reviewed commits have been landed. Closing PR #20565 and removing active labels.