WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
264450
[git-webkit] Handle multiple bugs associated with a single branch
https://bugs.webkit.org/show_bug.cgi?id=264450
Summary
[git-webkit] Handle multiple bugs associated with a single branch
Jonathan Bedard
Reported
2023-11-08 16:13:59 PST
When we set a branch config value in git-webkit, that value is appended to any existing value for that branch. On PR branches, this isn't a problem because the user should only have a single bug associated with the branch. But for cherry-picks, multiple cherry-picks are very likely to be done on the same branch. Since the oldest values come first, the commit message template will tend to prefer the older value to the newer ones. Our commit message template should prefer newer values to older ones, and generally, should not allow duplicates of the same value. "not allowing duplicates" is complicated by the fact that a user may store a newline delinated value, which will look like two independent values. This is particularly relevant for bugs.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2023-11-08 16:14:24 PST
<
rdar://problem/118144919
>
Jonathan Bedard
Comment 2
2023-11-08 16:22:25 PST
Pull request:
https://github.com/WebKit/WebKit/pull/20200
EWS
Comment 3
2023-11-17 16:52:36 PST
Committed
270921@main
(88a259f2f225): <
https://commits.webkit.org/270921@main
> Reviewed commits have been landed. Closing PR #20200 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug