Bug 264451 - Convert fast/multicol/unsplittable-inline-block to reftest
Summary: Convert fast/multicol/unsplittable-inline-block to reftest
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-11-08 16:18 PST by Ahmad Saleem
Modified: 2023-12-03 03:10 PST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-11-08 16:18:46 PST
SSIA

It is to merge: https://chromium.googlesource.com/chromium/blink/+/196812ff8a2aa414ba1ca11e3d986024492ef154

___

Benefits - less pain while trying to do Next Generation Layout and more resilient to pixel changes. Might be faster as well?

___

Thanks!
Comment 1 Radar WebKit Bug Importer 2023-11-15 16:19:18 PST
<rdar://problem/118480616>
Comment 2 Ahmad Saleem 2023-11-16 03:40:10 PST
Rather than doing a lot of these in separate, I think it would be good to do all in one go:

overflow-unsplittable.html -> https://chromium.googlesource.com/chromium/blink/+/af75803fb156e9d52bf83e0163644a0822bd47ae

positive-leading.html -> https://chromium.googlesource.com/chromium/blink/+/5b05f1dd0e703286eb4e97cb1b05bf65453460e0

single-line.html -> https://chromium.googlesource.com/chromium/blink/+/509992e4571c71cab5e507bded8d0cf5bc073fc2

first-letter-skip-out-of-flow.html -> https://chromium.googlesource.com/chromium/blink/+/3fd4582c67231539aee8ae95ab2e5c9aa26ff760

and there are few more, I will post all here and will go to do one PR for all.
Comment 3 EWS 2023-12-03 03:10:55 PST
Committed 271437@main (506a269b05e7): <https://commits.webkit.org/271437@main>

Reviewed commits have been landed. Closing PR #21212 and removing active labels.