264476 – Assess whether 'dumpSVGCharacterDataMapValue' in 'SVGTextLayoutAttributes.cpp' is needed and also its usage in 'SVGTextLayoutAttributes::dump()'

Bug 264476 - Assess whether 'dumpSVGCharacterDataMapValue' in 'SVGTextLayoutAttributes.cpp' is needed and also its usage in 'SVGTextLayoutAttributes::dump()'

Summary: Assess whether 'dumpSVGCharacterDataMapValue' in 'SVGTextLayoutAttributes.cpp...

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	SVG (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Nobody

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2023-11-09 05:13 PST by Ahmad Saleem
Modified:	2023-11-18 03:12 PST (History)
CC List:	5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Ahmad Saleem 2023-11-09 05:13:38 PST

Hi Team,

Do we need these?

https://searchfox.org/wubkat/source/Source/WebCore/rendering/svg/SVGTextLayoutAttributes.cpp#45

&

https://searchfox.org/wubkat/source/Source/WebCore/rendering/svg/SVGTextLayoutAttributes.cpp#58

Just wanted to raise for input purposes.

Thanks!

Comment 1 Ahmad Saleem 2023-11-09 07:37:24 PST

Trying to run it through EWS as draft PR to see what happens - https://github.com/WebKit/WebKit/pull/20230

Comment 2 Radar WebKit Bug Importer 2023-11-16 05:14:11 PST

<rdar://problem/118505986>

Comment 3 EWS 2023-11-18 03:12:49 PST

Committed 270937@main (d42df0c67eea): <https://commits.webkit.org/270937@main>

Reviewed commits have been landed. Closing PR #20230 and removing active labels.