WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
264537
SVG SMIL Animation Lengths (to, from, by) should disallow invalid lengths (e.g., leading space)
https://bugs.webkit.org/show_bug.cgi?id=264537
Summary
SVG SMIL Animation Lengths (to, from, by) should disallow invalid lengths (e....
Ahmad Saleem
Reported
2023-11-09 16:39:13 PST
Hi Team, While going through SVG Animations failure, I came across three failing tests around SVG Animations and Length: WPT Tests: svglength-animation-invalid-value-1.html , svglength-animation-invalid-value-2.html , svglength-animation-invalid-value-e.html WPT Tests Link:
https://wpt.fyi/results/svg/animations?label=master&label=experimental&aligned=&q=svglength-animation-invalid-value
- Web-Spec:
https://www.w3.org/TR/2001/REC-smil-animation-20010904/#ToAttribute
>> Leading and trailing white space, and white space before and after semicolon separators, will be ignored.
>> If any values (i.e., the argument-values for from, to, by or values attributes) are not legal, the animation will have no effect (see also Handling Syntax Errors). Similarly, if none of the from, to, by or values attributes are specified, the animation will have no effect.
Just wanted to raise so we can fix it and track it. Thanks!
Attachments
Add attachment
proposed patch, testcase, etc.
Ahmad Saleem
Comment 1
2023-11-09 16:41:22 PST
Might be to do trim here?:
https://searchfox.org/wubkat/source/Source/WebCore/svg/SVGAnimationElement.cpp#315
https://searchfox.org/wubkat/source/Source/WebCore/svg/SVGAnimationElement.cpp#320
https://searchfox.org/wubkat/source/Source/WebCore/svg/SVGAnimationElement.cpp#325
Ahmad Saleem
Comment 2
2023-11-09 16:45:56 PST
> No spaces between number and unit > No spaces before value. > No spaces after number and unit.
^ These are invalid ones, which we need to fix.
Ahmad Saleem
Comment 3
2023-11-09 16:49:04 PST
Or here:
https://searchfox.org/wubkat/source/Source/WebCore/svg/SVGAnimationElement.cpp#558
Radar WebKit Bug Importer
Comment 4
2023-11-16 16:40:20 PST
<
rdar://problem/118537155
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug