Bug 264564 - Add missing 'optional' in constructor of 'RTCIceCandidate.idl' as per WebIDL Specification
Summary: Add missing 'optional' in constructor of 'RTCIceCandidate.idl' as per WebIDL ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: BrowserCompat, InRadar, WPTImpact
Depends on:
Blocks:
 
Reported: 2023-11-10 03:43 PST by Ahmad Saleem
Modified: 2023-11-10 11:23 PST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-11-10 03:43:01 PST
Hi Team,

While looking into 'IDLHarness' failures in WebRTC world, I noticed that we are failing two tests (but this is just about one of them), where we didn't align with web-spec.

Web-Spec: https://w3c.github.io/webrtc-pc/#rtcicecandidate-interface

Current: constructor(RTCIceCandidateInit candidateInitDict);

Expected: constructor(optional RTCIceCandidateInit candidateInitDict = {});

___

WPT Test: https://wpt.live/webrtc/idlharness.https.window.html

^ From it, it progresses > RTCIceCandidate interface object length

___

Just wanted to raise, so we can fix it.

Adding relevant tags as well.

Thanks!
Comment 1 EWS 2023-11-10 11:22:31 PST
Committed 270552@main (ee948a9bf670): <https://commits.webkit.org/270552@main>

Reviewed commits have been landed. Closing PR #20302 and removing active labels.
Comment 2 Radar WebKit Bug Importer 2023-11-10 11:23:17 PST
<rdar://problem/118243459>