Bug 264619 - Add assertions to ensure memcpySpan and memsetSpan are used on trivially copyable spans
Summary: Add assertions to ensure memcpySpan and memsetSpan are used on trivially copy...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-11-10 13:27 PST by Michael Catanzaro
Modified: 2023-11-15 17:07 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2023-11-10 13:27:56 PST 
Add assertions to ensure memcpySpan and memsetSpan are used on trivially copyable spans

Bad things are likely to happen if used on objects with custom constructors or destructors or assignment operators, because they won't be executed. Add safety checks for this.
Comment 1 Michael Catanzaro 2023-11-10 13:29:33 PST 
Pull request: https://github.com/WebKit/WebKit/pull/20330
Comment 2 EWS 2023-11-15 17:06:12 PST 
Committed 270796@main (3ae0cd09762d): <https://commits.webkit.org/270796@main>

Reviewed commits have been landed. Closing PR #20330 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-11-15 17:07:20 PST 
<rdar://problem/118483239>