Bug 264654 - Don't make the decision to cache a DisplayList for a TextRun depend on the rendering update frame rate
Summary: Don't make the decision to cache a DisplayList for a TextRun depend on the re...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-11-10 21:15 PST by Said Abou-Hallawa
Modified: 2023-11-15 12:05 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2023-11-10 21:15:25 PST 
Currently, caching a DisplayList for the TextRun happens only if the last 30 frames happened in about a second. If the frame rate is lower than 30 FPS, we prevent the caching. The assumption is any animation should be faster than 30 FPS.

So when the frame rate is low, we make it even worse by preventing the caching. The caching should happen if the same TextRun is displayed very often (say >= 20) regardless of the current frame rate.
Comment 1 Said Abou-Hallawa 2023-11-10 21:15:45 PST 
rdar://118259180
Comment 2 Said Abou-Hallawa 2023-11-10 21:23:15 PST 
Pull request: https://github.com/WebKit/WebKit/pull/20357
Comment 3 EWS 2023-11-15 12:05:26 PST 
Committed 270781@main (42af8a3d2bb4): <https://commits.webkit.org/270781@main>

Reviewed commits have been landed. Closing PR #20357 and removing active labels.