Bug 264658 - [GTK] Switch to use GTK4 by default
Summary: [GTK] Switch to use GTK4 by default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Diego Pino
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2023-11-10 23:26 PST by Carlos Garcia Campos
Modified: 2023-11-15 10:52 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2023-11-10 23:26:20 PST 
Change USE_GTK4 default value to ON.
Comment 1 Carlos Garcia Campos 2023-11-10 23:27:51 PST 
Pull request: https://github.com/WebKit/WebKit/pull/20361
Comment 2 EWS 2023-11-15 04:57:46 PST 
Committed 270765@main (80028d273216): <https://commits.webkit.org/270765@main>

Reviewed commits have been landed. Closing PR #20361 and removing active labels.
Comment 3 Diego Pino 2023-11-15 09:23:53 PST 
After this change Ubuntu LTS bot was failing with the following error:

https://build.webkit.org/#/builders/68/builds/29215

```
CMake Error at Source/cmake/WebKitFeatures.cmake:323 (message):
  USE_GTK4 conflicts with USE_SOUP2.  You must disable one or the other.
Call Stack (most recent call first):
  Source/cmake/WebKitFeatures.cmake:331 (_WEBKIT_OPTION_ENFORCE_CONFLICTS)
  Source/cmake/WebKitFeatures.cmake:356 (_WEBKIT_OPTION_ENFORCE_ALL_CONFLICTS)
  Source/cmake/OptionsGTK.cmake:164 (WEBKIT_OPTION_END)
  Source/cmake/WebKitCommon.cmake:232 (include)
  CMakeLists.txt:21 (include)
```

The bot built with USE_SOUP2=ON. After removing this setting the build was failing because libgtk4-dev was not installed. This bot builds using only system libraries, so libgtk4-dev has to be added to the list of WebKitGTK dependency packages.
Comment 4 Diego Pino 2023-11-15 09:24:25 PST 
Re-opening for pull request https://github.com/webkit/webkit/pull/20546
Comment 5 EWS 2023-11-15 10:51:54 PST 
Committed 270775@main (cc67c85e30f9): <https://commits.webkit.org/270775@main>

Reviewed commits have been landed. Closing PR #20546 and removing active labels.