WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
264695
Use dynamicDowncast<T> more in the DOM
https://bugs.webkit.org/show_bug.cgi?id=264695
Summary
Use dynamicDowncast<T> more in the DOM
Chris Dumez
Reported
2023-11-11 19:08:53 PST
Use dynamicDowncast<T> more in the DOM instead of is<T>() + downcast<T>(). It is less error-prone and often results in more concise code. I am also hoping to have downcast<>() do a type check on release builds in the future. It is currently too expensive to do so but it may become affordable if we use dynamicDowncast<T>() instead when possible.
Attachments
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2023-11-11 19:13:46 PST
Pull request:
https://github.com/WebKit/WebKit/pull/20384
EWS
Comment 2
2023-11-12 13:54:10 PST
Committed
270617@main
(b1c357dd6e0f): <
https://commits.webkit.org/270617@main
> Reviewed commits have been landed. Closing PR #20384 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2023-11-12 13:55:14 PST
<
rdar://problem/118305393
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug