Bug 264718 - Avoid divide-by-zero in webrtc::StreamStatisticianImpl::BitrateReceived
Summary: Avoid divide-by-zero in webrtc::StreamStatisticianImpl::BitrateReceived
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-11-12 20:11 PST by David Kilzer (:ddkilzer)
Modified: 2023-11-13 12:03 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2023-11-12 20:11:12 PST 
Avoid divide-by-zero in webrtc::StreamStatisticianImpl::BitrateReceived().

This can occur when invalid data is received.

It has no effect on ARM architectures (the result is zero), but a floating-point exception occurs on Intel.

<rdar://117912996>
Comment 1 David Kilzer (:ddkilzer) 2023-11-12 20:13:28 PST 
Pull request: https://github.com/WebKit/WebKit/pull/20399
Comment 2 EWS 2023-11-13 12:03:36 PST 
Committed 270656@main (01dea93c203e): <https://commits.webkit.org/270656@main>

Reviewed commits have been landed. Closing PR #20399 and removing active labels.