Bug 264739 - [GStreamer] Video goes blank on some platforms after playback ends
Summary: [GStreamer] Video goes blank on some platforms after playback ends
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Enrique Ocaña
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-11-13 06:08 PST by Enrique Ocaña
Modified: 2023-11-15 05:38 PST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Enrique Ocaña 2023-11-13 06:08:12 PST
On some downstream platforms, the video gets black after playback finishes.

This happens because https://bugs.webkit.org/show_bug.cgi?id=89122 used to set the pipeline to NULL, although later https://bugs.webkit.org/show_bug.cgi?id=117354 set it to READY. This change deinitializes a big part of the pipeline, which should otherwise stay in a working state if the state was PLAUSED as it should be without those changes. While on desktop platforms the last video frame is still kept and shown, on some downstream platforms using a custom multimedia subsystem the deinitialization destroys internal resources and makes that last video frame not to be visible anymore.

The original purpose of the mentioned bugs was to avoid having the audio device opened after the video finished. This was relevant in 2012, when many platforms still used ALSA as a sound system, but it's not so relavant nowadays, when PulseAudio is the usual choice on desktop.
Comment 1 Enrique Ocaña 2023-11-13 06:46:35 PST
Pull request: https://github.com/WebKit/WebKit/pull/20415
Comment 2 Enrique Ocaña 2023-11-14 06:32:19 PST
Pull request: https://github.com/WebKit/WebKit/pull/20480
Comment 3 EWS 2023-11-15 05:37:31 PST
Committed 270766@main (0df38135ebe5): <https://commits.webkit.org/270766@main>

Reviewed commits have been landed. Closing PR #20415 and removing active labels.
Comment 4 Radar WebKit Bug Importer 2023-11-15 05:38:14 PST
<rdar://problem/118450697>