Bug 264747 - [web-animations] `KeyframeValue` and `AcceleratedEffectKeyframe` should derive from a shared base class
Summary: [web-animations] `KeyframeValue` and `AcceleratedEffectKeyframe` should deriv...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks: 250970 264756 264796
  Show dependency tree / graph
 
Reported: 2023-11-13 08:42 PST by Antoine Quint
Modified: 2023-11-13 22:50 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2023-11-13 08:42:23 PST 
As part of the work on threaded animation resolution (see bug 250970), we will need to have the keyframe interpolation logic currently contained in `KeyframeEffect` also apply to `AcceleratedEffect`. This will require a fair amount of refactoring to move all the relevant code in a shared base class for both `KeyframeEffect` and `AcceleratedEffect`.

The first step towards this goal is to have the keyframe class backing those animation effect classes, `KeyframeValue` and `AcceleratedEffectKeyframe`, use a shared base class.
Comment 1 Antoine Quint 2023-11-13 08:48:11 PST 
Pull request: https://github.com/WebKit/WebKit/pull/20420
Comment 2 EWS 2023-11-13 11:03:05 PST 
Committed 270648@main (893f4b23e527): <https://commits.webkit.org/270648@main>

Reviewed commits have been landed. Closing PR #20420 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-11-13 11:04:16 PST 
<rdar://problem/118344599>