Bug 264756 - [web-animations] determining the interpolation interval should be shared in `KeyframeInterpolation`
Summary: [web-animations] determining the interpolation interval should be shared in `...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on: 264747
Blocks: 250970 264796
  Show dependency tree / graph
 
Reported: 2023-11-13 11:15 PST by Antoine Quint
Modified: 2023-11-13 22:50 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2023-11-13 11:15:20 PST 
Currently the code to determine the interpolation interval, the "from" and "to" keyframes, is contained within `KeyframeEffect::setAnimatedPropertiesInStyle()`. As part of the work on threaded animation resolution (see bug 250970), we will need to share this logic with `AcceleratedEffect` as well. Now that we have a shared concept of a keyframe (see bug 264747), we can add a method to `KeyframeInterpolation` for that purpose with whatever virtual methods are required on a new share base class for `AcceleratedEffect` and `KeyframeEffect`.
Comment 1 Antoine Quint 2023-11-13 11:21:46 PST 
Pull request: https://github.com/WebKit/WebKit/pull/20428
Comment 2 EWS 2023-11-13 22:25:01 PST 
Committed 270692@main (9bafc5fbd3e0): <https://commits.webkit.org/270692@main>

Reviewed commits have been landed. Closing PR #20428 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-11-13 22:26:14 PST 
<rdar://problem/118375013>