Bug 264759 - Follow-up to 270645@main to address review feedback
Summary: Follow-up to 270645@main to address review feedback
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-11-13 11:42 PST by Chris Dumez
Modified: 2023-11-13 15:06 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2023-11-13 11:42:45 PST 
Follow-up to 270645@main to address review feedback from Darin. Use Vector constructor / WTF::map() when possible instead of an append*() function.

There are a couple of cases in 270645@main where I keep using append*() even though they were calling reserveInitialCapacity() before because the vectors in question have an inline buffer and doing a Vector move assignment may end up having to copy the values in the inline buffers over.
Comment 1 Chris Dumez 2023-11-13 11:45:40 PST 
Pull request: https://github.com/WebKit/WebKit/pull/20431
Comment 2 EWS 2023-11-13 15:05:37 PST 
Committed 270679@main (1dfe581ad7a8): <https://commits.webkit.org/270679@main>

Reviewed commits have been landed. Closing PR #20431 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-11-13 15:06:24 PST 
<rdar://problem/118358370>