WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
264759
Follow-up to
270645@main
to address review feedback
https://bugs.webkit.org/show_bug.cgi?id=264759
Summary
Follow-up to 270645@main to address review feedback
Chris Dumez
Reported
2023-11-13 11:42:45 PST
Follow-up to
270645@main
to address review feedback from Darin. Use Vector constructor / WTF::map() when possible instead of an append*() function. There are a couple of cases in
270645@main
where I keep using append*() even though they were calling reserveInitialCapacity() before because the vectors in question have an inline buffer and doing a Vector move assignment may end up having to copy the values in the inline buffers over.
Attachments
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2023-11-13 11:45:40 PST
Pull request:
https://github.com/WebKit/WebKit/pull/20431
EWS
Comment 2
2023-11-13 15:05:37 PST
Committed
270679@main
(1dfe581ad7a8): <
https://commits.webkit.org/270679@main
> Reviewed commits have been landed. Closing PR #20431 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2023-11-13 15:06:24 PST
<
rdar://problem/118358370
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug