Bug 264796 - [web-animations] interpolating keyframes should be shared in `KeyframeInterpolation`
Summary: [web-animations] interpolating keyframes should be shared in `KeyframeInterpo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on: 264747 264756
Blocks: 250970
  Show dependency tree / graph
 
Reported: 2023-11-13 22:50 PST by Antoine Quint
Modified: 2023-11-14 00:53 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2023-11-13 22:50:32 PST 
Currently the code to interpolate keyframes is contained within `KeyframeEffect::setAnimatedPropertiesInStyle()`. As part of the work on threaded animation resolution (see bug 250970), we will need to share this logic with `AcceleratedEffect` as well. Now that we have a shared concept of a keyframe (see bug 264747) and shared code to determine the interpolation interval (see bug 264756), we can add a method to `KeyframeInterpolation` for the purpose of interpolation and whatever virtual methods are required to support it.
Comment 1 Antoine Quint 2023-11-13 22:59:43 PST 
Pull request: https://github.com/WebKit/WebKit/pull/20464
Comment 2 EWS 2023-11-14 00:52:20 PST 
Committed 270700@main (5dfffd1d9c0c): <https://commits.webkit.org/270700@main>

Reviewed commits have been landed. Closing PR #20464 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-11-14 00:53:13 PST 
<rdar://problem/118380665>