Bug 264859 - Replace strongThis by protectedThis
Summary: Replace strongThis by protectedThis
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jean-Yves Avenard [:jya]
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-11-14 20:19 PST by Jean-Yves Avenard [:jya]
Modified: 2023-11-15 00:16 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Yves Avenard [:jya] 2023-11-14 20:19:37 PST 
From webkit coding style:
https://webkit.org/code-style-guidelines/#names-protectors-this

"Ref and RefPtr objects meant to protect this from deletion should be named "protectedThis".
Comment 1 Radar WebKit Bug Importer 2023-11-14 20:19:53 PST 
<rdar://problem/118434279>
Comment 2 Fujii Hironori 2023-11-14 20:27:13 PST 
Chris said we should update the style guideline in favor of the smart pointer guideline.

> we can get rid of protectedThis from our codebase

https://github.com/WebKit/WebKit/wiki/Smart-Pointer-Usage-Guidelines
Comment 3 Chris Dumez 2023-11-14 20:28:30 PST 
(In reply to Fujii Hironori from comment #2)
> Chris said we should update the style guideline in favor of the smart
> pointer guideline.
> 
> > we can get rid of protectedThis from our codebase
> 
> https://github.com/WebKit/WebKit/wiki/Smart-Pointer-Usage-Guidelines

Not in lambda captures, which I think is what Jean-Yves is talking about.
Comment 4 Jean-Yves Avenard [:jya] 2023-11-14 20:30:54 PST 
Pull request: https://github.com/WebKit/WebKit/pull/20520
Comment 5 EWS 2023-11-15 00:16:47 PST 
Committed 270757@main (c72b2982933d): <https://commits.webkit.org/270757@main>

Reviewed commits have been landed. Closing PR #20520 and removing active labels.