Bug 264880 - [GTK] Crash in AcceleratedSurfaceDMABuf::RenderTargetEGLImage::create()
Summary: [GTK] Crash in AcceleratedSurfaceDMABuf::RenderTargetEGLImage::create()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oriol Brufau
URL:
Keywords: Regression
Depends on:
Blocks: 263309
  Show dependency tree / graph
 
Reported: 2023-11-15 08:43 PST by Oriol Brufau
Modified: 2023-11-16 22:53 PST (History)
2 users (show)

See Also:

Attachments
Output of webkit://gpu (6.44 KB, application/json)
2023-11-16 11:09 PST, Oriol Brufau 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oriol Brufau 2023-11-15 08:43:09 PST 
I get a crash when using ./Tools/Scripts/run-minibrowser --gtk


```
1   0x7f9d0655bb99 WTFCrash
2   0x7f9d0968d8f6 WebKit::AcceleratedSurfaceDMABuf::RenderTargetEGLImage::create(unsigned long, WebCore::IntSize const&, WebKit::DMABufRendererBufferFormat const&)
3   0x7f9d0968e786 WebKit::AcceleratedSurfaceDMABuf::SwapChain::nextTarget()
4   0x7f9d0968e7ed WebKit::AcceleratedSurfaceDMABuf::willRenderFrame()
5   0x7f9d091a44ad WebKit::ThreadedCompositor::renderLayerTree()
6   0x7f9d06609adc WTF::RunLoop::TimerBase::TimerBase(WTF::RunLoop&)::{lambda(void*)#1}::_FUN(void*)
7   0x7f9d0660a4af WTF::RunLoop::{lambda(_GSource*, int (*)(void*), void*)#1}::_FUN(_GSource*, int (*)(void*), void*)
8   0x7f9d0236a527 g_main_context_dispatch
9   0x7f9d023c7888 g_main_context_iterate.constprop.0
10  0x7f9d02369d7f g_main_loop_run
11  0x7f9d0660a5e0 WTF::RunLoop::run()
12  0x7f9d06595596 WTF::Thread::entryPoint(WTF::Thread::NewThreadContext*)
13  0x7f9d0660de89 WTF::wtfThreadEntryPoint(void*)
14  0x7f9d01d6325a start_thread
15  0x7f9d01debfc4 clone
```

The code reads dmabufFormat.modifiers[0] but dmabufFormat.modifiers is empty.
Comment 1 Oriol Brufau 2023-11-15 08:50:31 PST 
Pull request: https://github.com/WebKit/WebKit/pull/20543
Comment 2 Carlos Garcia Campos 2023-11-16 00:25:47 PST 
Could you provide the output of webkit://gpu ?
Comment 3 Oriol Brufau 2023-11-16 11:09:02 PST 
Created attachment 468627 [details]
Output of webkit://gpu
Comment 4 EWS 2023-11-16 22:53:14 PST 
Committed 270866@main (803d9c8905c3): <https://commits.webkit.org/270866@main>

Reviewed commits have been landed. Closing PR #20543 and removing active labels.