Bug 264962 - history properties should throw SecurityError when not in a fully active Document
Summary: history properties should throw SecurityError when not in a fully active Docu...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: History (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: sideshowbarker
URL:
Keywords: InRadar, WPTImpact
Depends on:
Blocks:
 
Reported: 2023-11-16 09:34 PST by Ahmad Saleem
Modified: 2024-02-07 18:18 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-11-16 09:34:50 PST 
Hi Team,

While going through WebKit / Safari specific failure, I came across another and I just wanted to raise bug so we can track it.

WPT Test Case: https://wpt.fyi/results/html/browsers/history/the-history-interface/history_properties_only_fully_active.html?label=master&label=experimental&aligned=&q=the-history-interface

WPT Test Case Link: http://wpt.live/html/browsers/history/the-history-interface/history_properties_only_fully_active.html

Blink Commit: https://chromium-review.googlesource.com/c/chromium/src/+/633823

Web-Spec: https://html.spec.whatwg.org/#shared-history-push/replace-state-steps

"If document is not fully active, then throw a "SecurityError" DOMException."

Just wanted to raise so we can fix it.

Thanks!
Comment 1 sideshowbarker 2023-11-20 15:29:39 PST 
Pull request: https://github.com/WebKit/WebKit/pull/20764
Comment 2 Radar WebKit Bug Importer 2023-11-23 09:35:55 PST 
<rdar://problem/118750576>
Comment 3 EWS 2024-02-07 18:18:38 PST 
Committed 274260@main (e4cbd15de56a): <https://commits.webkit.org/274260@main>

Reviewed commits have been landed. Closing PR #20764 and removing active labels.