Bug 264981 - Unified build fixes on macOS
Summary: Unified build fixes on macOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-11-16 13:39 PST by Yury Semikhatsky
Modified: 2023-11-17 09:36 PST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2023-11-16 13:39:44 PST
We are getting a few unified build errors in Playwright with the recent roll:
Comment 1 Yury Semikhatsky 2023-11-16 13:40:19 PST
In file included from /Users/yurys/webkit/WebKitBuild/Release/DerivedSources/WebKit/unified-sources/UnifiedSource41-mm.mm:1:
In file included from /Users/yurys/webkit/Source/WebKit/UIProcess/Inspector/mac/WKInspectorResourceURLSchemeHandler.mm:33:
In file included from /Users/yurys/webkit/Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.h:34:
In file included from /Users/yurys/webkit/Source/WebKit/UIProcess/WebPageProxy.h:31:
/Users/yurys/webkit/Source/WebKit/Platform/IPC/MessageSender.h:47:38: error: inline function 'IPC::MessageSender::send<Messages::WebInspectorUI::UpdateFindString>'
      is not defined [-Werror,-Wundefined-inline]
    template<typename T> inline bool send(T&& message); // Defined in MessageSenderInlines.h.
                                     ^
In file included from /Users/yurys/webkit/WebKitBuild/Release/DerivedSources/WebKit/unified-sources/UnifiedSource41-mm.mm:4:
/Users/yurys/webkit/Source/WebKit/UIProcess/Inspector/mac/WebInspectorUIProxyMac.mm:315:22: note: used here
    m_inspectorPage->send(Messages::WebInspectorUI::UpdateFindString(WebKit::stringForFind()));
                     ^
1 error generated.




In file included from /Users/yurys/webkit/WebKitBuild/Release/DerivedSources/WebKit/unified-sources/UnifiedSource30-mm.mm:1:
In file included from /Users/yurys/webkit/Source/WebKit/UIProcess/API/Cocoa/_WKSystemPreferences.mm:27:
/Users/yurys/webkit/Source/WebKit/UIProcess/API/Cocoa/_WKSystemPreferencesInternal.h:29:66: error: no matching literal operator for call to 'operator""_s' with
      arguments of types 'const char *' and 'unsigned long', and no matching literal operator template
constexpr auto WKLockdownModeEnabledKey = "WKLockdownModeEnabled"_s;
                                                                 ^
1 error generated.




In file included from /Users/yurys/webkit/WebKitBuild/Release/DerivedSources/WebKit/unified-sources/UnifiedSource28-mm.mm:1:
/Users/yurys/webkit/Source/WebKit/UIProcess/API/Cocoa/_WKFrameTreeNode.mm:49:25: error: incomplete type 'API::FrameInfo' named in nested name specifier
    return wrapper(API::FrameInfo::create(WebKit::FrameInfoData(_node->info()), &_node->page())).autorelease();
                   ~~~~~^~~~~~~~~~~
In file included from /Users/yurys/webkit/WebKitBuild/Release/DerivedSources/WebKit/unified-sources/UnifiedSource28-mm.mm:1:
In file included from /Users/yurys/webkit/Source/WebKit/UIProcess/API/Cocoa/_WKFrameTreeNode.mm:29:
In file included from /Users/yurys/webkit/Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h:27:
In file included from /Users/yurys/webkit/Source/WebKit/UIProcess/Cocoa/WKShareSheet.h:26:
/Users/yurys/webkit/Source/WebKit/UIProcess/API/C/WKAPICast.h:57:7: note: forward declaration of 'API::FrameInfo'
class FrameInfo;
      ^
1 error generated.



In file included from /Users/yurys/webkit/WebKitBuild/Release/DerivedSources/WebKit/unified-sources/UnifiedSource28-mm.mm:1:
/Users/yurys/webkit/Source/WebKit/UIProcess/API/Cocoa/_WKFrameTreeNode.mm:50:12: error: no matching function for call to 'wrapper'
    return wrapper(API::FrameInfo::create(WebKit::FrameInfoData(_node->info()), &_node->page())).autorelease();
           ^~~~~~~
Comment 2 Yury Semikhatsky 2023-11-16 13:41:17 PST
Pull request: https://github.com/WebKit/WebKit/pull/20629
Comment 3 EWS 2023-11-17 09:35:14 PST
Committed 270895@main (c15c2658c262): <https://commits.webkit.org/270895@main>

Reviewed commits have been landed. Closing PR #20629 and removing active labels.
Comment 4 Radar WebKit Bug Importer 2023-11-17 09:36:13 PST
<rdar://problem/118568812>