Bug 265025 - Correcting menu button event trigger location
Summary: Correcting menu button event trigger location
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: DoNotImportToRadar, PlatformOnly
Depends on:
Blocks:
 
Reported: 2023-11-17 06:00 PST by Ahmad Saleem
Modified: 2024-04-12 14:08 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-11-17 06:00:07 PST 
Hi Team,

While going through Blink's Commit, I came across 'Windows' specific fix due to 'contextmenu' keyboard key.

Blink Commit: https://chromium.googlesource.com/chromium/blink/+/d240a9d4fd0f048d4492293d15f6f89ed1509364

WebKit Source: https://searchfox.org/wubkat/rev/114aa2c8594807cbc34dd5dff48a9e2addfd1e00/Source/WebCore/page/EventHandler.cpp#3478

This compiles:

} else if (focusedElement) {
        IntRect boundingBoxRect = focusedElement->boundsInRootViewSpace();
        location = IntPoint(boundingBoxRect.center());
___

Although the test will fail on 'mac' and since I was not able to test on 'Windows', so I am just raising it, if you want to merge or have issue with 'win-cairo' port.

If it is not reproducible then please close.

Thanks!
Comment 1 Radar WebKit Bug Importer 2023-11-24 06:01:14 PST 
<rdar://problem/118771259>