Bug 265101 - Make a couple more http/tests/security tests use window.internals.isFullyActive(Document&)
Summary: Make a couple more http/tests/security tests use window.internals.isFullyActi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: sideshowbarker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-11-18 18:56 PST by sideshowbarker
Modified: 2023-12-05 12:41 PST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sideshowbarker 2023-11-18 18:56:17 PST
https://commits.webkit.org/270737@main added a new window.internals.isFullyActive(Document&) function — intended for tests where it’s necessary to ensure whether or not a particular document is fully active — and used that function to update (fix) the http/tests/security/xss-DENIED-script-inject-into-inactive-window2-pson.html test, which had been flaky since it was last updated in https://commits.webkit.org/269235@main.

And in that https://commits.webkit.org/269235@main change which caused the http/tests/security/xss-DENIED-script-inject-into-inactive-window2-pson.html test to become flaky, its companion tests at LayoutTests/http/tests/security/xss-DENIED-script-inject-into-inactive-window2.html and LayoutTests/http/tests/security/xss-DENIED-script-inject-into-inactive-window3.html had also been updated in the same way as the http/tests/security/xss-DENIED-script-inject-into-inactive-window2-pson.html had been before it was subsequently fixed.

And while those two other companion tests have not yet been flaky, we should also (re)update them to now use window.internals.isFullyActive(Document&) — in order to ensure they’re actually testing what they’re intended to be testing.
Comment 1 sideshowbarker 2023-11-18 19:20:38 PST
Pull request: https://github.com/WebKit/WebKit/pull/20715
Comment 2 Radar WebKit Bug Importer 2023-11-25 18:57:13 PST
<rdar://problem/118796437>
Comment 3 EWS 2023-12-05 12:41:52 PST
Committed 271565@main (a2d071de9311): <https://commits.webkit.org/271565@main>

Reviewed commits have been landed. Closing PR #20715 and removing active labels.