Bug 265108 - Initial <input type=checkbox switch> animation support
Summary: Initial <input type=checkbox switch> animation support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks: 259380
  Show dependency tree / graph
 
Reported: 2023-11-19 08:51 PST by Anne van Kesteren
Modified: 2023-11-26 12:10 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anne van Kesteren 2023-11-19 08:51:36 PST 
.
Comment 1 Anne van Kesteren 2023-11-19 08:59:35 PST 
Pull request: https://github.com/WebKit/WebKit/pull/20724
Comment 2 EWS 2023-11-26 05:58:22 PST 
Committed 271118@main (0a64dd544211): <https://commits.webkit.org/271118@main>

Reviewed commits have been landed. Closing PR #20724 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-11-26 05:59:16 PST 
<rdar://problem/118805169>
Comment 4 Fujii Hironori 2023-11-26 11:57:06 PST 
Windows port can't compile. I'm going to reuse this ticket to fix the problem.

C:\webkit\Source\WebCore\rendering\style\RenderStyle.h(381,17): error: inline function 'WebCore::RenderStyle::hasEffectiveAppearance' is not defined [-Werror,-Wundefined-inline]
  381 |     inline bool hasEffectiveAppearance() const;
      |                 ^
C:\webkit\Source\WebCore\html/CheckboxInputType.cpp(143,43): note: used here
  143 |     ASSERT(element()->renderer()->style().hasEffectiveAppearance());
      |                                           ^
1 error generated.
Comment 5 Fujii Hironori 2023-11-26 12:06:20 PST 
Pull request: https://github.com/WebKit/WebKit/pull/20910
Comment 6 EWS 2023-11-26 12:10:05 PST 
Committed 271125@main (f3616fd9bff9): <https://commits.webkit.org/271125@main>

Reviewed commits have been landed. Closing PR #20910 and removing active labels.