Bug 265143 - [IFC] Move "content has position dependent width" traversal to RenderText
Summary: [IFC] Move "content has position dependent width" traversal to RenderText
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-11-20 08:18 PST by zalan
Modified: 2023-11-20 17:51 PST (History)
12 users (show)

See Also:

Attachments
Patch (20.00 KB, patch)
2023-11-20 08:24 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (20.00 KB, patch)
2023-11-20 11:36 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (20.00 KB, patch)
2023-11-20 15:25 PST, zalan 		no flags Details | Formatted Diff | Diff
[fast-cq]Patch (20.25 KB, patch)
2023-11-20 17:16 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2023-11-20 08:18:51 PST 
ssia
Comment 1 zalan 2023-11-20 08:24:40 PST 
Created attachment 468682 [details]
Patch
Comment 2 Antti Koivisto 2023-11-20 08:29:45 PST 
Comment on attachment 468682 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=468682&action=review

> Source/WebCore/layout/layouttree/LayoutInlineTextBox.h:58
> +inline void InlineTextBox::updateContent(String newContent, bool canUseSimpleFontCodePath, bool canUseSimplifiedContentMeasuring, bool hasPositionDependentContentWidth)

maybe we'll need an OptionSet soon
Comment 3 zalan 2023-11-20 08:30:13 PST 
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 468682 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=468682&action=review
> 
> > Source/WebCore/layout/layouttree/LayoutInlineTextBox.h:58
> > +inline void InlineTextBox::updateContent(String newContent, bool canUseSimpleFontCodePath, bool canUseSimplifiedContentMeasuring, bool hasPositionDependentContentWidth)
> 
> maybe we'll need an OptionSet soon
very true!
Comment 4 zalan 2023-11-20 11:36:31 PST 
Created attachment 468688 [details]
Patch
Comment 5 zalan 2023-11-20 15:25:38 PST 
Created attachment 468692 [details]
Patch
Comment 6 zalan 2023-11-20 17:16:09 PST 
Created attachment 468694 [details]
[fast-cq]Patch
Comment 7 EWS 2023-11-20 17:50:15 PST 
Committed 270993@main (d36b968cd91a): <https://commits.webkit.org/270993@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 468694 [details].
Comment 8 Radar WebKit Bug Importer 2023-11-20 17:51:24 PST 
<rdar://problem/118666798>