RESOLVED FIXED265166
[IFC] Pre-compute "content has strong directionality character" bit 
https://bugs.webkit.org/show_bug.cgi?id=265166
Summary [IFC] Pre-compute "content has strong directionality character" bit
alan
Reported 2023-11-20 17:09:53 PST
ssia
Attachments
Patch (16.94 KB, patch)
2023-11-20 17:58 PST, alan 		no flags
DetailsFormatted DiffDiff
[fast-cq]Patch (17.61 KB, patch)
2023-11-21 06:17 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2023-11-20 17:58:15 PST
Created attachment 468695 [details] Patch
Antti Koivisto
Comment 2 2023-11-21 06:02:23 PST
Comment on attachment 468695 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=468695&action=review > Source/WebCore/layout/layouttree/LayoutInlineTextBox.cpp:37 > +InlineTextBox::InlineTextBox(String content, bool isCombined, WTF::OptionSet<ContentCharacteristic> contentCharacteristicSet, RenderStyle&& style, std::unique_ptr<RenderStyle>&& firstLineStyle) no need to say WTF:: > Source/WebCore/layout/layouttree/LayoutInlineTextBox.h:45 > + InlineTextBox(String, bool isCombined, WTF::OptionSet<ContentCharacteristic>, RenderStyle&&, std::unique_ptr<RenderStyle>&& firstLineStyle = nullptr); (anywhere)
alan
Comment 3 2023-11-21 06:17:36 PST
Created attachment 468709 [details] [fast-cq]Patch
EWS
Comment 4 2023-11-21 07:14:36 PST
Committed 271016@main (dc839aa94c04): <https://commits.webkit.org/271016@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 468709 [details].
Radar WebKit Bug Importer
Comment 5 2023-11-21 07:15:15 PST
<rdar://problem/118687678>
Note You need to log in before you can comment on or make changes to this bug.