Bug 265209 - Stop sending 2 Close frames from client-close_wsh
Summary: Stop sending 2 Close frames from client-close_wsh
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: GoodFirstBug, InRadar
Depends on:
Blocks:
 
Reported: 2023-11-21 10:47 PST by Ahmad Saleem
Modified: 2023-12-03 16:55 PST (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-11-21 10:47:03 PST 
Hi Team,

I don't know whether we use same 'python' script or same test infrastructure but came across following Blink commit, which might be something we have faced or we don't.

Blink Commit: https://chromium.googlesource.com/chromium/blink/+/2138625fb49a80512464cf45fc1244015054c8de

WebKit Source: https://searchfox.org/wubkat/source/LayoutTests/http/tests/websocket/tests/hybi/client-close_wsh.py#21

Just wanted to get input so raising it.

Thanks!
Comment 1 Alexey Proskuryakov 2023-11-25 13:43:46 PST 
Yes, we use this code in tests. Looks like it's referenced form two tests, one of which is marked as flaky:

LayoutTests/http/tests//websocket/tests/hybi/client-close-2.html
LayoutTests/http/tests//websocket/tests/hybi/client-close.html
Comment 2 Radar WebKit Bug Importer 2023-11-28 10:48:16 PST 
<rdar://problem/118889240>
Comment 3 EWS 2023-12-03 16:55:39 PST 
Committed 271447@main (d4b790b2d8a6): <https://commits.webkit.org/271447@main>

Reviewed commits have been landed. Closing PR #21235 and removing active labels.