Bug 265295 - Speedometer 3: Sync wait in RemoteLayerWithRemoteRenderingBackingStoreCollection::prepareBackingStoresForDisplay
Summary: Speedometer 3: Sync wait in RemoteLayerWithRemoteRenderingBackingStoreCollect...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matt Woodrow
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-11-23 16:56 PST by Matt Woodrow
Modified: 2023-12-09 00:54 PST (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Woodrow 2023-11-23 16:56:17 PST 
Having a synchronous call to prepareBackingStoresForDisplay blocks the main thread, while the GPU Process existing commands (like canvas drawing from rAF).

We should be able to avoid this in the common case, and just asynchronously let the GPU know that we're starting layer drawing for a frame.


<rdar://116792212>
Comment 1 Matt Woodrow 2023-11-23 16:58:19 PST 
Pull request: https://github.com/WebKit/WebKit/pull/20858
Comment 2 EWS 2023-12-08 11:20:43 PST 
Committed 271747@main (3dd074a9e5d2): <https://commits.webkit.org/271747@main>

Reviewed commits have been landed. Closing PR #20858 and removing active labels.
Comment 3 Fujii Hironori 2023-12-09 00:54:17 PST 
Windows port regressed.
  Bug 266138 – REGRESSION(271747@main): [Win] ASSERTION FAILED: canSafelyBeUsed() under WebKit::RemoteImageBufferProxy::streamConnection