Bug 265306 - Allow to chain NativePromise::ThenCommand even if it returned void
Summary: Allow to chain NativePromise::ThenCommand even if it returned void
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jean-Yves Avenard [:jya]
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-11-24 05:29 PST by Jean-Yves Avenard [:jya]
Modified: 2023-11-29 03:48 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Yves Avenard [:jya] 2023-11-24 05:29:17 PST 
Currently, to be able to chain promises, the previous then/whenSettled handler must return another NativePromise. We could make it so that if it returns void, it behaves like a revolved GenericPromise was returned.
Comment 1 Radar WebKit Bug Importer 2023-11-24 05:29:31 PST 
<rdar://problem/118770512>
Comment 2 Jean-Yves Avenard [:jya] 2023-11-24 05:31:43 PST 
Pull request: https://github.com/WebKit/WebKit/pull/20867
Comment 3 EWS 2023-11-29 03:48:53 PST 
Committed 271267@main (ab34eaa17f5d): <https://commits.webkit.org/271267@main>

Reviewed commits have been landed. Closing PR #20867 and removing active labels.