Bug 265322 - [JSC] Wasm GC struct members should be naturally aligned
Summary: [JSC] Wasm GC struct members should be naturally aligned
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-11-24 10:03 PST by Joseph Griego
Modified: 2023-11-27 08:53 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Griego 2023-11-24 10:03:54 PST 
At present, e.g. ref members can be placed anywhere within the JSWebAssemblyStruct::m_payload allocation; for concurrent JIT on 32-bit (and, AIUI, concurrent GC on 64-bit,) these need to be 8-byte aligned.

Also, I suspect aligning the scalar types could be a slight performance win on ARM.
Comment 1 Joseph Griego 2023-11-24 10:37:14 PST 
Pull request: https://github.com/WebKit/WebKit/pull/20878
Comment 2 EWS 2023-11-27 08:52:47 PST 
Committed 271146@main (c95abf8658be): <https://commits.webkit.org/271146@main>

Reviewed commits have been landed. Closing PR #20878 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-11-27 08:53:15 PST 
<rdar://problem/118835663>