RESOLVED FIXED265373
[WinCairo] Read GITHUB_TOKEN from env when updating WebKitRequirements 
https://bugs.webkit.org/show_bug.cgi?id=265373
Summary [WinCairo] Read GITHUB_TOKEN from env when updating WebKitRequirements
Max Schmitt
Reported 2023-11-27 03:26:22 PST
When we build WinCairo we receive this error sometimes: Updating WebKitRequirementsWin64.zip... No existing release found. Seeking latest release from WebKitForWindows/WebKitRequirements... HTTP Error 403: rate limit exceeded This is because there is no GitHub API token assigned to the request, so it thinks that our IP does exceed their rate limits. Solution: Read the API token from env and add it accordingly if set. Affected code: https://github.com/WebKit/WebKit/blob/2502481c805f5c8a62af86eeef6794d85dc08098/Tools/Scripts/download-github-release.py#L75 This gets called here: https://github.com/WebKit/WebKit/blob/2502481c805f5c8a62af86eeef6794d85dc08098/Tools/Scripts/update-webkit-wincairo-libs.py#L45
Attachments
Add attachment proposed patch, testcase, etc.
Max Schmitt
Comment 1 2023-11-27 04:45:55 PST
Pull request: https://github.com/WebKit/WebKit/pull/20927
EWS
Comment 2 2023-11-27 11:06:59 PST
Committed 271154@main (46ea518570fd): <https://commits.webkit.org/271154@main> Reviewed commits have been landed. Closing PR #20927 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2023-11-27 11:07:18 PST
<rdar://problem/118841966>
Note You need to log in before you can comment on or make changes to this bug.