Bug 265402 - Add IPV6 support to built-in server for run-benchmarks
Summary: Add IPV6 support to built-in server for run-benchmarks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-11-27 13:42 PST by hysu
Modified: 2023-12-01 15:33 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description hysu 2023-11-27 13:42:52 PST 
Follow-up bug report to: https://bugs.webkit.org/show_bug.cgi?id=259835 (Investigate the possibility of replacing twisted http server in run-benchmark with python3 http.server)

`--http-server-type builtin` only serves on IPV4 at the moment. While this should be the default, we should also be able to serve on IPV6 for harnesses that require it, and be able to automatically detect which one to use.

The simplest way to implement this would be to override `address_family = socket.AF_INET6` in SimpleHTTPRequestHandler, and to switch when an address contains colons instead of periods.
Comment 1 Radar WebKit Bug Importer 2023-11-27 13:52:24 PST 
<rdar://problem/118850024>
Comment 2 james 2023-11-28 10:49:53 PST 
Pull request: https://github.com/WebKit/WebKit/pull/21008
Comment 3 EWS 2023-12-01 15:33:01 PST 
Committed 271412@main (ecc5b337e0f9): <https://commits.webkit.org/271412@main>

Reviewed commits have been landed. Closing PR #21008 and removing active labels.