Bug 265472 - AX: associatedPluginParent is accessing the main thread every time a notification is fired
Summary: AX: associatedPluginParent is accessing the main thread every time a notifica...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: Safari Technology Preview
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-11-28 14:11 PST by Dominic Mazzoni
Modified: 2023-11-28 19:27 PST (History)
9 users (show)

See Also:

Attachments
Patch (1.52 KB, patch)
2023-11-28 14:17 PST, Dominic Mazzoni 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dominic Mazzoni 2023-11-28 14:11:38 PST 
Tiny optimization: every time AXPostNotificationWithUserInfo is called, it checks associatedPluginParent, which currently goes to the main thread. Since it's almost always nil unless we happen to be on a PDF element, associatedPluginParent should check the isolated object without going to the main thread.
Comment 1 Radar WebKit Bug Importer 2023-11-28 14:11:53 PST 
<rdar://problem/118898537>
Comment 2 Dominic Mazzoni 2023-11-28 14:17:11 PST 
Created attachment 468792 [details]
Patch
Comment 3 EWS 2023-11-28 19:27:55 PST 
Committed 271258@main (7db75daadf99): <https://commits.webkit.org/271258@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 468792 [details].