Bug 265626
| Summary: | import-expectations.json errors on WPT css/css-sizing | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Karl Dubost <karlcow> |
| Component: | CSS | Assignee: | Ahmad Saleem <ahmad.saleem792> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | ntim, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari 17 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 261986 | ||
| Bug Blocks: | |||
Karl Dubost
In import-expectations.json, there are two files, it makes
git webkit pr
complains:
ERROR: LayoutTests/imported/w3c/resources/import-expectations.json:70: 'web-platform-tests/css/css-sizing/block-size-with-min-or-max-content-table-1a.html' is not a directory [json/syntax] [5]
ERROR: LayoutTests/imported/w3c/resources/import-expectations.json:71: 'web-platform-tests/css/css-sizing/block-size-with-min-or-max-content-table-1b.html' is not a directory [json/syntax] [5]
This was added by
https://github.com/WebKit/WebKit/commit/e180ca76e7e0337d925a231b4d8759369fabda6d#diff-8e10a6004f5e7069a47556c338eb9a8d87d0a0eb73fbe1d58a739c66a0c19e26R69
This should be fixed, probably by importing the full CSS-sizing directory of WPT and erasing these two lines.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/119014020>
Ahmad Saleem
I tried importing full in this PR but messed-up in rebase: https://github.com/WebKit/WebKit/pull/19728
I can try it on weekend to fix this. Unless if someone want to take a stab early on.
Tim Nguyen (:ntim)
Bug 266230 is going to remove these, but we should still aim to import the whole directory in bug 263907, otherwise we'll lose the current tests if we ever automate import.
*** This bug has been marked as a duplicate of bug 266230 ***
Ahmad Saleem
(In reply to Tim Nguyen (:ntim) from comment #3)
> Bug 266230 is going to remove these, but we should still aim to import the
> whole directory in bug 263907, otherwise we'll lose the current tests if we
> ever automate import.
>
> *** This bug has been marked as a duplicate of bug 266230 ***
Apologies! I am out of order and not feeling well. Will import it later.