Bug 278503
| Summary: | WPT linter should by run by check-webkit-style | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | gsnedders, simon.fraser, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Simon Fraser (smfr)
I added some WPT tests a few commits ago. But when I later try to export them, the linter finds some errors:
ERROR:lint:css/css-backgrounds/background-clip/clip-text-text-decorations-ref.html: Don't use Ahem as a system font, use /fonts/ahem.css (AHEM SYSTEM FONT)
ERROR:lint:css/css-backgrounds/background-clip/clip-text-text-decorations.html: Don't use Ahem as a system font, use /fonts/ahem.css (AHEM SYSTEM FONT)
INFO:lint:
INFO:lint:There were 2 errors (AHEM SYSTEM FONT: 2)
INFO:lint:You must fix all errors; for details on how to fix them, see
INFO:lint:https://web-platform-tests.org/writing-tests/lint-tool.html
INFO:lint:
INFO:lint:However, instead of fixing a particular error, it's sometimes
INFO:lint:OK to add a line to the lint.ignore file in the root of the
INFO:lint:web-platform-tests directory to make the lint tool ignore it.
INFO:lint:
INFO:lint:For example, to make the lint tool ignore all 'AHEM SYSTEM FONT'
INFO:lint:errors in the css/css-backgrounds/background-clip/clip-text-text-decorations.html file,
INFO:lint:you could add the following line to the lint.ignore file.
INFO:lint:
INFO:lint:AHEM SYSTEM FONT: css/css-backgrounds/background-clip/clip-text-text-decorations.html
ERROR: The wpt linter detected 2 linting error(s). Please address the above errors before attempting to export changes to the web-platform-test repository.
This means I can't directly export those WPT to the wpt repo; I'll have to make a PR by hand.
Ideally these errors would have been caught at `git webkit pr` time.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/134458714>
Simon Fraser (smfr)
This should also have been caught at webkit commit time:
ERROR:lint:css/css-backgrounds/background-clip/clip-border-area-background-geometry-ref.html:15: Whitespace at EOL (TRAILING WHITESPACE)
ERROR:lint:css/css-backgrounds/background-clip/clip-border-area-border-on-top-ref.html:13: Whitespace at EOL (TRAILING WHITESPACE)
ERROR:lint:css/css-backgrounds/background-clip/clip-border-area-ref.html:13: Whitespace at EOL (TRAILING WHITESPACE)
ERROR:lint:css/css-backgrounds/background-clip/clip-border-area-ref.html:17: Whitespace at EOL (TRAILING WHITESPACE)
ERROR:lint:css/css-backgrounds/background-clip/clip-border-area-ref.html:29: Whitespace at EOL (TRAILING WHITESPACE)
ERROR:lint:css/css-backgrounds/background-clip/clip-border-area.html:20: Whitespace at EOL (TRAILING WHITESPACE)
ERROR:lint:css/css-backgrounds/background-clip/clip-border-area.html:24: Whitespace at EOL (TRAILING WHITESPACE)
ERROR:lint:css/css-backgrounds/background-clip/clip-border-area.html:36: Whitespace at EOL (TRAILING WHITESPACE)
Sam Sneddon [:gsnedders]
*** This bug has been marked as a duplicate of bug 257853 ***