RESOLVED DUPLICATE of bug 257853278503
WPT linter should by run by check-webkit-style 
https://bugs.webkit.org/show_bug.cgi?id=278503
Summary WPT linter should by run by check-webkit-style
Simon Fraser (smfr)
Reported 2024-08-21 18:03:45 PDT
I added some WPT tests a few commits ago. But when I later try to export them, the linter finds some errors: ERROR:lint:css/css-backgrounds/background-clip/clip-text-text-decorations-ref.html: Don't use Ahem as a system font, use /fonts/ahem.css (AHEM SYSTEM FONT) ERROR:lint:css/css-backgrounds/background-clip/clip-text-text-decorations.html: Don't use Ahem as a system font, use /fonts/ahem.css (AHEM SYSTEM FONT) INFO:lint: INFO:lint:There were 2 errors (AHEM SYSTEM FONT: 2) INFO:lint:You must fix all errors; for details on how to fix them, see INFO:lint:https://web-platform-tests.org/writing-tests/lint-tool.html INFO:lint: INFO:lint:However, instead of fixing a particular error, it's sometimes INFO:lint:OK to add a line to the lint.ignore file in the root of the INFO:lint:web-platform-tests directory to make the lint tool ignore it. INFO:lint: INFO:lint:For example, to make the lint tool ignore all 'AHEM SYSTEM FONT' INFO:lint:errors in the css/css-backgrounds/background-clip/clip-text-text-decorations.html file, INFO:lint:you could add the following line to the lint.ignore file. INFO:lint: INFO:lint:AHEM SYSTEM FONT: css/css-backgrounds/background-clip/clip-text-text-decorations.html ERROR: The wpt linter detected 2 linting error(s). Please address the above errors before attempting to export changes to the web-platform-test repository. This means I can't directly export those WPT to the wpt repo; I'll have to make a PR by hand. Ideally these errors would have been caught at `git webkit pr` time.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2024-08-21 18:04:18 PDT
<rdar://problem/134458714>
Simon Fraser (smfr)
Comment 2 2024-08-21 18:19:34 PDT
This should also have been caught at webkit commit time: ERROR:lint:css/css-backgrounds/background-clip/clip-border-area-background-geometry-ref.html:15: Whitespace at EOL (TRAILING WHITESPACE) ERROR:lint:css/css-backgrounds/background-clip/clip-border-area-border-on-top-ref.html:13: Whitespace at EOL (TRAILING WHITESPACE) ERROR:lint:css/css-backgrounds/background-clip/clip-border-area-ref.html:13: Whitespace at EOL (TRAILING WHITESPACE) ERROR:lint:css/css-backgrounds/background-clip/clip-border-area-ref.html:17: Whitespace at EOL (TRAILING WHITESPACE) ERROR:lint:css/css-backgrounds/background-clip/clip-border-area-ref.html:29: Whitespace at EOL (TRAILING WHITESPACE) ERROR:lint:css/css-backgrounds/background-clip/clip-border-area.html:20: Whitespace at EOL (TRAILING WHITESPACE) ERROR:lint:css/css-backgrounds/background-clip/clip-border-area.html:24: Whitespace at EOL (TRAILING WHITESPACE) ERROR:lint:css/css-backgrounds/background-clip/clip-border-area.html:36: Whitespace at EOL (TRAILING WHITESPACE)
Sam Sneddon [:gsnedders]
Comment 3 2024-08-22 10:53:13 PDT
*** This bug has been marked as a duplicate of bug 257853 ***
Note You need to log in before you can comment on or make changes to this bug.