Bug 297919
| Summary: | [export-w3c-test-changes] Remove support for exporting Bugzilla attachments | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Sneddon [:gsnedders] <gsnedders> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | bfan2, ntim, ryanhaddad, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=257854 https://bugs.webkit.org/show_bug.cgi?id=274079 |
||
Sam Sneddon [:gsnedders]
The Bugzilla attachment path is a relatively untrodden path (in fact, I don't know when anyone last actually used it), and makes things like bug 257854 (WPT export should not use the bug URL in the commit subject (title)) and bug 274079 ([export-w3c-test-changes] Use original author when committing) harder to fix, because we don't have all the context of a git commit to based our export on.
This does mean that for things landing as patches via Bugzilla WPT changes can only be exported after landing, but I think this is a workable limitation.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/159206512>
Tim Nguyen (:ntim)
> This does mean that for things landing as patches via Bugzilla WPT changes can only be exported after landing, but I think this is a workable limitation.
Is that true? If you rely on `export-w3c-test-changes -g HEAD -c` after checking out the PR, I think it should work fine and should use the git codepath? It should also work locally as well.
EWS has support for checking out bugzilla patches somehow, so it will also work with https://github.com/WebKit/WebKit/pull/49257 .
It should probably be fine to remove this codepath otherwise.