WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
102907
[GTK] TargetFrame and innerNodeFrame confused
https://bugs.webkit.org/show_bug.cgi?id=102907
Summary
[GTK] TargetFrame and innerNodeFrame confused
Allan Sandfeld Jensen
Reported
2012-11-21 02:26:35 PST
While trying to clarify the point returned by HitTestResult, I have gone through all the call-sites using the point, and have noticed what I can only assume are errors in webkithittestresult.cpp. First of all you use targetFrame instead of the frame of the innernode to translate to window coordinates. This is likely wrong since targetframe is the frame the link your are hovering will be opened in (open link in different frame/open link in new window feature). Secondly your fall-back logic while probably not necessary uses the point in innerNodeFrame, it should probably instead use the point in mainFrame instead and translate from the mainframe. Alternatively you can always translate from the main-frame coordinates once the patch for
bug #98139
lands.
Attachments
Patch
(2.46 KB, patch)
2012-11-21 02:54 PST
,
Allan Sandfeld Jensen
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Allan Sandfeld Jensen
Comment 1
2012-11-21 02:54:39 PST
Created
attachment 175397
[details]
Patch
Martin Robinson
Comment 2
2013-05-16 07:58:09 PDT
Comment on
attachment 175397
[details]
Patch Thanks!
Allan Sandfeld Jensen
Comment 3
2013-05-16 08:18:33 PDT
Comment on
attachment 175397
[details]
Patch Clearing flags on attachment: 175397 Committed
r150182
: <
http://trac.webkit.org/changeset/150182
>
Allan Sandfeld Jensen
Comment 4
2013-05-16 08:18:38 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug