RESOLVED FIXED 119418
[CSS] Introduce new structure to pass image orientation values. 
https://bugs.webkit.org/show_bug.cgi?id=119418
Summary [CSS] Introduce new structure to pass image orientation values.
Gyuyoung Kim
Reported 2013-08-01 17:41:33 PDT
As commented on https://bugs.webkit.org/show_bug.cgi?id=92330#c6, we need to consider to use new structure in order to reduce argument count. Patch is coming.
Attachments
WIP (44.88 KB, patch)
2013-08-04 09:13 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch for ews (44.93 KB, patch)
2013-08-08 00:25 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch for ews (45.87 KB, patch)
2013-08-08 03:36 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (45.85 KB, patch)
2013-08-11 18:30 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Rebased Patch (45.98 KB, patch)
2013-08-13 22:41 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2013-08-04 09:13:50 PDT
Created attachment 208093 [details] WIP
Gyuyoung Kim
Comment 2 2013-08-04 16:32:05 PDT
Beth, how do you think approach of this patch ?
Beth Dakin
Comment 3 2013-08-05 12:47:37 PDT
I think this is a good approach!
Gyuyoung Kim
Comment 4 2013-08-08 00:25:53 PDT
Created attachment 208315 [details] Patch for ews
Gyuyoung Kim
Comment 5 2013-08-08 00:27:09 PDT
(In reply to comment #3) > I think this is a good approach! Ok, let's go ahead. But, now I'm in Summer vacation. So, my update may be late by end of this week.
Build Bot
Comment 6 2013-08-08 00:58:25 PDT
Comment on attachment 208315 [details] Patch for ews Attachment 208315 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1389231
Build Bot
Comment 7 2013-08-08 01:18:04 PDT
Comment on attachment 208315 [details] Patch for ews Attachment 208315 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1433085
Gyuyoung Kim
Comment 8 2013-08-08 03:36:15 PDT
Created attachment 208323 [details] Patch for ews
Gyuyoung Kim
Comment 9 2013-08-11 18:30:11 PDT
Created attachment 208506 [details] Patch
Gyuyoung Kim
Comment 10 2013-08-11 18:31:03 PDT
Beth, could you review this patch ?
Gyuyoung Kim
Comment 11 2013-08-13 22:41:00 PDT
Created attachment 208699 [details] Rebased Patch
WebKit Commit Bot
Comment 12 2013-08-14 21:45:24 PDT
Comment on attachment 208699 [details] Rebased Patch Clearing flags on attachment: 208699 Committed r154088: <http://trac.webkit.org/changeset/154088>
WebKit Commit Bot
Comment 13 2013-08-14 21:45:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.