WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
121403
MediaStream API: Adding an async RTCPeerConnection::addIceCandidate
https://bugs.webkit.org/show_bug.cgi?id=121403
Summary
MediaStream API: Adding an async RTCPeerConnection::addIceCandidate
Eric Carlson
Reported
2013-09-15 14:26:11 PDT
Consider merging/adapting
https://chromium.googlesource.com/chromium/blink/+/5bd81fda88d48dd2780832246e7d1ab973ee7a1d
RTCPeerConnection::addIceCandidate has changed to by async.
Attachments
Proposed patch
(8.87 KB, patch)
2013-09-16 19:30 PDT
,
Eric Carlson
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Eric Carlson
Comment 1
2013-09-16 19:30:24 PDT
Created
attachment 211857
[details]
Proposed patch
WebKit Commit Bot
Comment 2
2013-09-17 07:17:48 PDT
Comment on
attachment 211857
[details]
Proposed patch Rejecting
attachment 211857
[details]
from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 211857, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output:
http://webkit-queues.appspot.com/results/1869424
Eric Carlson
Comment 3
2013-09-17 07:51:59 PDT
Committed
r155954
:
https://trac.webkit.org/r155954
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug