RESOLVED WONTFIX 147675
Rename Mutex to DeprecatedMutex 
https://bugs.webkit.org/show_bug.cgi?id=147675
Summary Rename Mutex to DeprecatedMutex
Filip Pizlo
Reported 2015-08-04 18:47:41 PDT
Patch forthcoming.
Attachments
it's a start (198.24 KB, patch)
2015-08-04 18:48 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (230.38 KB, patch)
2015-08-04 20:19 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (227.48 KB, patch)
2015-08-04 21:26 PDT, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-08-04 18:48:56 PDT
Created attachment 258256 [details] it's a start
Filip Pizlo
Comment 2 2015-08-04 20:19:49 PDT
Created attachment 258261 [details] the patch
Filip Pizlo
Comment 3 2015-08-04 21:26:19 PDT
Created attachment 258263 [details] the patch
WebKit Commit Bot
Comment 4 2015-08-04 21:27:43 PDT
Attachment 258263 [details] did not pass style-queue: ERROR: Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:136: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/ThreadingPrimitives.h:97: The parameter name "mutex" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 130 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 5 2015-08-05 11:12:11 PDT
Comment on attachment 258263 [details] the patch r=me It's arguably premature to do this before we've proven that the new mutex is, in fact, better -- but I'll take a small gamble here.
Geoffrey Garen
Comment 6 2015-08-05 11:12:33 PDT
> ERROR: Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:136: > Place brace on its own line for function definitions. [whitespace/braces] > [4] > ERROR: Source/WTF/wtf/ThreadingPrimitives.h:97: The parameter name "mutex" > adds no information, so it should be removed. [readability/parameter_name] > [5] These are worth fixing, since we're here.
Anders Carlsson
Comment 7 2015-08-05 11:51:18 PDT
(In reply to comment #5) > Comment on attachment 258263 [details] > the patch > > r=me > > It's arguably premature to do this before we've proven that the new mutex > is, in fact, better -- but I'll take a small gamble here. Even if it isn't better, we should be using std::mutex in favor of WTF::(Deprecated)Mutex.
Filip Pizlo
Comment 8 2015-08-05 12:21:39 PDT
Landed in http://trac.webkit.org/changeset/187972
Filip Pizlo
Comment 9 2015-08-05 16:47:15 PDT
Rolled out in http://trac.webkit.org/changeset/188002
Note You need to log in before you can comment on or make changes to this bug.