WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
159955
Align CSSStyleDeclaration.setProperty() with the specification
https://bugs.webkit.org/show_bug.cgi?id=159955
Summary
Align CSSStyleDeclaration.setProperty() with the specification
Chris Dumez
Reported
2016-07-19 15:27:02 PDT
Align CSSStyleDeclaration.setProperty() with the specification: -
https://drafts.csswg.org/cssom/#the-cssstyledeclaration-interface
In particular: 1. The 'value' parameter should not be optional 2. The 'priority' parameter should treat null as the empty string rather than the string "null" 3. The 'priority' parameter's default value should be the empty string, not the string "undefined" 4. CSSStyleDeclaration.setProperty() should return early if 'priority' is not the empty string and is not an ASCII case-insensitive match for the string "important". Chrome matches the specification entirely. Firefox matches the specification with the exception that it does a case-sensitive match for "important".
Attachments
Patch
(10.64 KB, patch)
2016-07-19 15:54 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(10.84 KB, patch)
2016-07-19 16:29 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2016-07-19 15:54:33 PDT
Created
attachment 284065
[details]
Patch
Chris Dumez
Comment 2
2016-07-19 16:29:12 PDT
Created
attachment 284067
[details]
Patch
WebKit Commit Bot
Comment 3
2016-07-19 18:21:19 PDT
Comment on
attachment 284067
[details]
Patch Clearing flags on attachment: 284067 Committed
r203437
: <
http://trac.webkit.org/changeset/203437
>
WebKit Commit Bot
Comment 4
2016-07-19 18:21:25 PDT
All reviewed patches have been landed. Closing bug.
Simon Fraser (smfr)
Comment 5
2017-07-05 19:21:42 PDT
rdar://problem/33108273
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug