WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
174668
WebDriver: correctly handle main frame handles
https://bugs.webkit.org/show_bug.cgi?id=174668
Summary
WebDriver: correctly handle main frame handles
Carlos Garcia Campos
Reported
2017-07-19 23:58:12 PDT
When I switched to use std::optional instead of empty strings for the browsing contexts in WebDriver, I forgot that automation uses empty string for frames to refer to the main frame. We should handle that case, because we are currently considering empty strings as valid browsing context. It's not a big deal because Automation converts back the empty string received to the main frame, though. We should also ensure we close the current browsing context when switching to a new top level browsing context.
Attachments
Patch
(6.97 KB, patch)
2017-07-20 00:01 PDT
,
Carlos Garcia Campos
bburg
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1
2017-07-20 00:01:16 PDT
Created
attachment 315973
[details]
Patch
Blaze Burg
Comment 2
2017-07-20 10:26:23 PDT
Comment on
attachment 315973
[details]
Patch r=me
Carlos Garcia Campos
Comment 3
2017-07-21 02:43:24 PDT
Committed
r219721
: <
http://trac.webkit.org/changeset/219721
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug